Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel queries gracefully #276

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Cancel queries gracefully #276

merged 4 commits into from
Mar 21, 2024

Conversation

kmcginnes
Copy link
Collaborator

Issue #, if available: #265

Description of changes:

Fixes an issue where cancelling a query is not supported by the database server and the Graph Explorer server will crash.

Other changes:

  • Skip logging about "max retries reached" if max retries is 1
  • Move error JSON deserialization after log statements in case it fails
  • Log out response status and text on failed requests
  • Log failed cancellations as warnings

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.02%. Comparing base (2a2650e) to head (21b452c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   12.02%   12.02%           
=======================================
  Files         410      410           
  Lines       30480    30480           
  Branches      762      762           
=======================================
  Hits         3664     3664           
  Misses      26483    26483           
  Partials      333      333           
Flag Coverage Δ
unittests 12.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vkagamlyk vkagamlyk merged commit 527aa0f into aws:main Mar 21, 2024
3 checks passed
@kmcginnes kmcginnes deleted the cancel-gracefully branch March 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants