Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetch caching #280

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Mar 25, 2024

Issue #, if available: N/A

Description of changes

  • Removed local fetch caching logic
  • Removed fetch caching configuration in connection

Context

When the change was made to use POST for database queries (PR #206), it completely broke the local fetch caching that existed before. This makes the caching logic and configuration irrelevant and essentially dead code.

If we desire client side caching for network calls, we should lean on React Query caching, which is already being used by Graph Explorer in some ways. Removing the custom client side caching makes this transition simpler when it comes time.

Disclaimer

Important

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 12.19%. Comparing base (2744e93) to head (5c5b960).
Report is 3 commits behind head on main.

Files Patch % Lines
...ackages/graph-explorer/src/connector/useGEFetch.ts 0.00% 26 Missing ⚠️
...es/graph-explorer/src/connector/utils/anySignal.ts 0.00% 13 Missing ⚠️
...graph-explorer/src/connector/gremlin/useGremlin.ts 0.00% 2 Missing ⚠️
...explorer/src/connector/openCypher/useOpenCypher.ts 0.00% 2 Missing ⚠️
...s/graph-explorer/src/connector/sparql/useSPARQL.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   12.15%   12.19%   +0.03%     
==========================================
  Files         411      411              
  Lines       30575    30458     -117     
  Branches      776      777       +1     
==========================================
- Hits         3717     3713       -4     
+ Misses      26525    26412     -113     
  Partials      333      333              
Flag Coverage Δ
unittests 12.19% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes
Copy link
Collaborator Author

Rebased on main and fixed conflicts

vkagamlyk
vkagamlyk previously approved these changes Apr 2, 2024
Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiazcy xiazcy requested a review from michaelnchin April 2, 2024 19:45
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmcginnes !

Minor note, let's also remove the connection cache section from the README:
https://github.com/aws/graph-explorer?tab=readme-ov-file#connection-cache

@kmcginnes
Copy link
Collaborator Author

@michaelnchin Good catch! I've removed that section. Should be good now.

@michaelnchin michaelnchin merged commit 2e9d1fd into aws:main Apr 4, 2024
2 of 3 checks passed
@kmcginnes kmcginnes deleted the remove-fetch-caching branch April 5, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants