Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Connector Part 3 - Connector & cleanup #365

Merged
merged 10 commits into from
May 13, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented May 10, 2024

Description

  • Refactors Gremlin, openCypher, and SPARQL explorers to be functions
  • Refactors ConnectorProvider and context to be Recoil selectors instead

Validation

  • Regression across all query engines

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes changed the title Connector logic Refactor Connector Part 1 - Connector & cleanup May 10, 2024
@kmcginnes kmcginnes changed the title Refactor Connector Part 1 - Connector & cleanup Refactor Connector Part 3 - Connector & cleanup May 10, 2024
@kmcginnes kmcginnes requested a review from vkagamlyk May 10, 2024 21:44
@kmcginnes kmcginnes marked this pull request as ready for review May 10, 2024 21:44
@kmcginnes kmcginnes merged commit 4f740ec into aws:main May 13, 2024
1 check passed
@kmcginnes kmcginnes deleted the connector-logic branch May 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert connector & explorer code to simple TypeScript functions instead of React hooks and callbacks
2 participants