Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expand sidebar scrolling #436

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 14, 2024

Description

The expand sidebar scrolling is annoying to use when vertical height is limited. It was using percentage heights for sections of the UI.

Instead, I allow the full content beneath the vertex header to be scrolled. The expand button will be in the bottom corner if there is enough height to accomplish that without scrolling. If not, the user will need to scroll for the expand button.

When there are more than 5 neighbors, A "show more" button will appear. When clicked, all the neighbors will show. The user can collapse it again.

Validation

Here is a 30 second video showing off this new behavior.

CleanShot.2024-06-14.at.11.43.42.mp4

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 14, 2024 16:57
@kmcginnes kmcginnes marked this pull request as ready for review June 14, 2024 16:57
Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kmcginnes kmcginnes merged commit 391f2c9 into aws:main Jun 14, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-sidebar-scrolling branch June 14, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants