Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing defaultConnection file on startup #508

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

kmcginnes
Copy link
Collaborator

Description

I noticed that when running Graph Explorer in Neptune Notebook it would sometimes fail to get the default connections. I determined it is because every time the Notebook is rebooted another entry is added to the defaultConnection.json file. But it is missing a comma between them so it is invalid JSON and can't be parsed by the JavaScript code.

So instead, each startup will replace the existing defaultConnection.json file with the current environment values. This will ensure that only one connection is present in the file.

Validation

  • Tested in local docker environment with Neptune Notebook like settings

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes force-pushed the fix-appending-default-connection branch from 5b0f89f to e7bb3d6 Compare July 25, 2024 21:53
@kmcginnes kmcginnes marked this pull request as ready for review July 25, 2024 21:53
@kmcginnes kmcginnes merged commit 685d9a1 into aws:main Jul 26, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-appending-default-connection branch July 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants