Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker example script update #517

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jul 29, 2024

Description

Updates the SageMaker example script.

  • Adds CloudWatch logging to Docker container run command
  • Updates logging text to use product name Graph Explorer
  • Adds instructional comments to parts of script that the user must change manually
  • Removes parameter parsing, since version is not passed via script parameter in this case
  • Adds graph-notebook installation to better reflect full production Lifecycle used in Neptune Notebooks

Validation

  • Test in Neptune SageMaker

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@michaelnchin michaelnchin marked this pull request as ready for review July 30, 2024 05:00
@michaelnchin michaelnchin self-requested a review July 30, 2024 05:00
michaelnchin
michaelnchin previously approved these changes Jul 30, 2024
@kmcginnes kmcginnes merged commit 2480b03 into aws:main Jul 30, 2024
1 check passed
@kmcginnes kmcginnes deleted the sagemaker-update branch July 30, 2024 16:50
@kmcginnes kmcginnes linked an issue Aug 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update SageMaker example and docs
2 participants