Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix updater #544

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Fix prefix updater #544

merged 4 commits into from
Aug 12, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Aug 9, 2024

Description

This fixes an issue with RDF data sets that contain upper case characters in the URI. For example:

http://www.ExampleData.com/Entity

These uppercase characters would cause the prefix generator to miss the existing entry in the prefixes array, causing a new entry to be created. That new entry would be converted to lower case. On the next pass the same thing would happen looped to infinity.

This infinite loop would cause Graph Explorer to crash.

To fix, I made the search for an existing entry be case insensitive.

Validation

  • Tested with dataset that produces the crash
  • Added unit tests for case sensitivity

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review August 9, 2024 22:13
@kmcginnes kmcginnes merged commit f0e7c18 into aws:main Aug 12, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-prefix-updater branch August 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crash in RDF databases with upper case characters in the URI
2 participants