Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vite production server #565

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Aug 27, 2024

Description

Vite is the tool we use for fast development on the React client side. It has a feature to run as a server, but it is discouraged to use in production.

We require running the client side through the proxy server. But there was an option in the code to run the client by itself without the proxy server.

This PR removes those options.

  • Remove certificate handling in Vite config (still exists on the proxy server)
  • Remove PNPM script to launch Vite server

Validation

  • Smoke test

Related Issues

  • None

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes force-pushed the remove-vite-production-server branch from 08837b6 to 556d88c Compare August 27, 2024 17:10
@kmcginnes kmcginnes marked this pull request as ready for review August 27, 2024 17:13
@michaelnchin michaelnchin merged commit 9bc56c5 into aws:main Aug 27, 2024
1 check passed
@kmcginnes kmcginnes deleted the remove-vite-production-server branch August 28, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants