Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to latest Node version #615

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Update Dockerfile to latest Node version #615

merged 1 commit into from
Sep 14, 2024

Conversation

michaelnchin
Copy link
Member

Description

Updated the Dockerfile to use the latest Node version added in #614.

Validation

Verified via manual ECR deployment test.

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@michaelnchin michaelnchin merged commit 874ac52 into main Sep 14, 2024
1 check passed
@@ -2,7 +2,7 @@
FROM amazonlinux:2022
ARG NEPTUNE_NOTEBOOK
ENV NVM_DIR=/root/.nvm
ENV NODE_VERSION=v20.12.2
ENV NODE_VERSION=v20.17.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelnchin Thank you! I thought for sure I had updated this. Good catch.

@michaelnchin michaelnchin deleted the PR-614-Fix branch September 17, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants