Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in failed DefaultCallbackProvider constructor #1200

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/playback-issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
name: HLS/DASH/Console Playback Failure
about: Are you experiencing a failure when playing your streamed media?
title: "[Playback Failure]"
labels: Playback
assignees: ''

---

**NOTE:** This template is for failure to playback issues of HLS, DASH, and AWS console players. If the playback issue is related to GetMedia playback, please submit an issue on the [KVS Java Parser Library](https://github.com/aws/amazon-kinesis-video-streams-parser-library) repository. If the issue is related to HLS/DASH/Console, but the issue is not regarding a failure to playback (such as a latency issue or general question), please submit using the general question template.

### Brief one-liner description of the issue:
...

### Please include the following details:
- Problematic playback methods (HLS, DASH, and/or AWS Console), operating systems, browsers:
- ...
- Working playback methods (were you able to playback the stream using using any methods?), operating systems, browsers:
- ...
- Is the stream's data retention setting greater than 0?
- Does your stream meet the [KVS video playback track requirements](https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/video-playback-requirements.html)?
- If there are fragment decoding errors:
- Are fragment timestamps accurate, in the correct order, and have no duplicates? ([ListFragments](https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/API_reader_ListFragments.html) can be used to retrieve fragment information for a stream)
- Is your application encoding the frame data using the H.264 format?
- Does the resolution of the frames match the resolution specified in the Codec Private Data?
- Does the H.264 profile and level of the encoded frames match the profile and level specified in the Codec Private Data?
- Does the browser/OS support the profile/level combination?
- If there are HLS playback failures:
- Is the fragment duration less than 1 second? If yes, does issue persist with fragments longer than 1 second?
- Is each HLS streaming session URL being used by only one player at a time?
- Does each fragment have a consistent number of tracks, is not changing between having both an audio and video track and only a video track, and has consistent encoder settings (resolution and frame rate not changing between fragments in each track)?
- Does issue persist after fetching using GetHLSStreamingSessionURL with the ContainerFormat and DiscontinuityMode parameters set to different values?


### Logging
Add any relevant SDK and player logs. IMPORTANT NOTE: Please make sure to NOT share AWS access credentials under any circumstance! Please make sure they are not in the logs.

** If you would not like to open an issue to discuss your solution in open-platform, please email your question to kinesis-video-support@amazon.com **
4 changes: 2 additions & 2 deletions .github/build_windows.bat
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
call "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvars64.bat"
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
mkdir build
cd build
cmd.exe /c cmake -G "NMake Makefiles" ..
cmake -G "NMake Makefiles" -DBUILD_TEST=TRUE -DBUILD_GSTREAMER_PLUGIN=TRUE ..
cmake -G "NMake Makefiles" -DBUILD_TEST=TRUE -DBUILD_GSTREAMER_PLUGIN=TRUE -DPKG_CONFIG_EXECUTABLE="D:\\gstreamer\\1.0\\msvc_x86_64\\bin\\pkg-config.exe" ..
nmake
Loading