Update build.sh for Issue 330 #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning requests to 2.29.0 to avoid importing urllib3 2.0 and resolve the conflict with lack of support for that library in botocore to resolve Issues awslabs#330.
|
I have the same issue. The fix works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning requests to 2.29.0 to avoid importing urllib3 2.0 and resolve the conflict with lack of support for that library in botocore to resolve Issue #330.
Issue #, if available: 330
Description of changes:
Running as a library referenced in Glue 4 results in the exception:
from neptune_python_utils.glue_neptune_connection_info import GlueNeptuneConnectionInfo
File "/tmp/neptune_python_utils.zip/neptune_python_utils/glue_neptune_connection_info.py",
...
line 34, in import botocore.httpsession File "/home/spark/.local/lib/python3.10/site-packages/botocore/httpsession.py", line 21, in from urllib3.util.ssl_ import ( ImportError: cannot import name 'DEFAULT_CIPHERS' from 'urllib3.util.ssl_' (/tmp/neptune_python_utils.zip/urllib3/util/ssl_.py)
This is due to a conflict between botocore not supporting urllib3 2.0 and newer versions of releases using urllib3 2.0. By pinning releases to 2.29.0, it resolves this conflict. This was tested by running the old library in Glue 4 and failing then running the revised library in Glue 4 and completing successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.