From 2b9f835ad6f97720f4f93c73aa25bb15b6eb343e Mon Sep 17 00:00:00 2001 From: Michael Graeb Date: Fri, 9 Feb 2024 15:40:59 -0800 Subject: [PATCH] Fix a bunch of places we forget to aws_raise_error() --- source/event_stream_channel_handler.c | 2 +- source/event_stream_rpc_client.c | 2 +- source/event_stream_rpc_server.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/source/event_stream_channel_handler.c b/source/event_stream_channel_handler.c index 0e030b4..85c788d 100644 --- a/source/event_stream_channel_handler.c +++ b/source/event_stream_channel_handler.c @@ -447,7 +447,7 @@ static int s_process_write_message( (void)slot; (void)message; AWS_FATAL_ASSERT(!"The event-stream-channel-handler is not designed to be a mid-channel handler."); - return AWS_OP_ERR; + return aws_raise_error(AWS_ERROR_UNIMPLEMENTED); } static int s_increment_read_window(struct aws_channel_handler *handler, struct aws_channel_slot *slot, size_t size) { diff --git a/source/event_stream_rpc_client.c b/source/event_stream_rpc_client.c index dfadfa6..01ea4c2 100644 --- a/source/event_stream_rpc_client.c +++ b/source/event_stream_rpc_client.c @@ -500,7 +500,7 @@ static int s_send_protocol_message( struct event_stream_connection_send_message_args *args = aws_mem_calloc(connection->allocator, 1, sizeof(struct event_stream_connection_send_message_args)); - if (!message_args) { + if (!args) { AWS_LOGF_ERROR( AWS_LS_EVENT_STREAM_RPC_CLIENT, "id=%p: failed to allocate callback arguments %s.", diff --git a/source/event_stream_rpc_server.c b/source/event_stream_rpc_server.c index 4078903..3dff587 100644 --- a/source/event_stream_rpc_server.c +++ b/source/event_stream_rpc_server.c @@ -571,7 +571,7 @@ static int s_send_protocol_message( struct event_stream_connection_send_message_args *args = aws_mem_calloc(connection->allocator, 1, sizeof(struct event_stream_connection_send_message_args)); - if (!message_args) { + if (!args) { AWS_LOGF_ERROR( AWS_LS_EVENT_STREAM_RPC_SERVER, "id=%p: allocation of callback args failed with error %s",