Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for metrics, dimensions and namespace #112

Closed
markkuhn opened this issue Aug 19, 2022 · 0 comments · Fixed by #119
Closed

Add validation for metrics, dimensions and namespace #112

markkuhn opened this issue Aug 19, 2022 · 0 comments · Fixed by #119
Assignees
@markkuhn
Labels
enhancement New feature or request

Comments

@markkuhn
Copy link
Contributor

markkuhn commented Aug 19, 2022 •
edited
Loading

Related issues:

Instead of silently dropping non-compliant characters, the client will now throw an error if an invalid dimension is found according to specification here.
@markkuhn markkuhn changed the title Add validation for dimension value Add validation for dimensions Aug 19, 2022
This was referenced Aug 19, 2022
Closed
Closed
Merged
@markkuhn markkuhn self-assigned this Aug 24, 2022
@markkuhn markkuhn added the enhancement New feature or request label Aug 24, 2022
@markkuhn markkuhn changed the title Add validation for dimensions Add validation for metrics, dimensions and namespace Aug 25, 2022
@markkuhn markkuhn linked a pull request Sep 14, 2022 that will close this issue
Add validation for dimension, metric, namespace and timestamp #119
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markkuhn markkuhn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation for dimension, metric, namespace and timestamp markkuhn/aws-embedded-metrics-java
1 participant
@markkuhn