-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for .net 5 #176
Comments
Pinging @SteveSandersonMS and @danroth27: Due to life stuff I have not had the time to follow the Blazor .net 5 changes, so I would really appreciate you commenting on this issue with any changes I need to be aware of, or, as Steve did in the dotnet/aspnetcore#24484 issue, just |
Hi @egil. Besides dotnet/aspnetcore#24484, there are some project structure changing coming in .NET 5 that may affect any test projects you have: dotnet/aspnetcore#24371. |
@danroth27 if I understand that issue correctly, you are pushing out a new SDK type for Blazor? bUnit is just a (at least for now) a netstandard2.1 library, which users add to a Blazor class library which contains their tests. So if I understand correctly, bUnit itself does not need to do change anything. My test projects for bUnit will have to though, which is probably what you mean. |
Correct, that's my understand as well. This is just a heads up for any test projects you have. |
bUnit will have to release a new version that is compiled against Blazor’s 5.0.0 preview 8 or later binaries. Any version of bUnit compiled against older builds of Blazor won’t work if I understand correctly how bUnit works. This is because the change we made is source-back-compatible but not binary-back-compatible. |
Update: it looks like I managed to get this working in the related PR. Will have to verify with the upcoming preview 8 release. |
@danroth27 / @SteveSandersonMS / @captainsafia, if there any more changes to the rendered out markup in .net 5, like the attribute added to the markup to support scoped CSS (#186)? For the sematic html comparer to work I need to make it aware of these kind of things, since users cannot and should not include these in their excepted markup. |
Changes required to bUnit to be compatible with .net 5.
net5.0
(?) andnetstandard2.1
, to allow users still on earlier versions of Blazor to get the new featuresRenderTree*
types work - Optimize render tree building via RenderTreeFrameArrayBuilder dotnet/aspnetcore#24484The text was updated successfully, but these errors were encountered: