Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for .net 5 #176

Closed
3 tasks done
egil opened this issue Aug 4, 2020 · 7 comments · Fixed by #187
Closed
3 tasks done

Prepare for .net 5 #176

egil opened this issue Aug 4, 2020 · 7 comments · Fixed by #187
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed input needed When an issue requires input or suggestions
Milestone

Comments

@egil
Copy link
Member

egil commented Aug 4, 2020

Changes required to bUnit to be compatible with .net 5.

@egil egil added this to the v1.0.0 milestone Aug 4, 2020
@egil
Copy link
Member Author

egil commented Aug 5, 2020

Pinging @SteveSandersonMS and @danroth27: Due to life stuff I have not had the time to follow the Blazor .net 5 changes, so I would really appreciate you commenting on this issue with any changes I need to be aware of, or, as Steve did in the dotnet/aspnetcore#24484 issue, just @ me to the conversation on related issues in the aspnetcore repo.

@egil egil added enhancement New feature or request help wanted Extra attention is needed input needed When an issue requires input or suggestions labels Aug 5, 2020
@danroth27
Copy link

Hi @egil. Besides dotnet/aspnetcore#24484, there are some project structure changing coming in .NET 5 that may affect any test projects you have: dotnet/aspnetcore#24371.

@egil
Copy link
Member Author

egil commented Aug 10, 2020

Hi @egil. Besides dotnet/aspnetcore#24484, there are some project structure changing coming in .NET 5 that may affect any test projects you have: dotnet/aspnetcore#24371.

@danroth27 if I understand that issue correctly, you are pushing out a new SDK type for Blazor?

bUnit is just a (at least for now) a netstandard2.1 library, which users add to a Blazor class library which contains their tests. So if I understand correctly, bUnit itself does not need to do change anything.

My test projects for bUnit will have to though, which is probably what you mean.

@danroth27
Copy link

So if I understand correctly, bUnit itself does not need to do change anything.
My test projects for bUnit will have to though, which is probably what you mean.

Correct, that's my understand as well. This is just a heads up for any test projects you have.

@SteveSandersonMS
Copy link

bUnit will have to release a new version that is compiled against Blazor’s 5.0.0 preview 8 or later binaries.

Any version of bUnit compiled against older builds of Blazor won’t work if I understand correctly how bUnit works.

This is because the change we made is source-back-compatible but not binary-back-compatible.

@egil
Copy link
Member Author

egil commented Aug 10, 2020

bUnit will have to release a new version that is compiled against Blazor’s 5.0.0 preview 8 or later binaries.

SteveSandersonMS will I be able to do that by having multiple target frameworks in my .csproj and some msbuild conditionals that picks different Blazor packages as I describes above?

I want to keep support for .net 3.x Blazor.

Update: it looks like I managed to get this working in the related PR. Will have to verify with the upcoming preview 8 release.

@egil egil mentioned this issue Aug 12, 2020
10 tasks
@egil egil linked a pull request Aug 12, 2020 that will close this issue
10 tasks
@egil egil self-assigned this Aug 12, 2020
@egil
Copy link
Member Author

egil commented Aug 15, 2020

@danroth27 / @SteveSandersonMS / @captainsafia, if there any more changes to the rendered out markup in .net 5, like the attribute added to the markup to support scoped CSS (#186)?

For the sematic html comparer to work I need to make it aware of these kind of things, since users cannot and should not include these in their excepted markup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed input needed When an issue requires input or suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants