Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-RPC API: User's Password #282

Closed
c0da opened this issue Oct 5, 2017 · 5 comments
Closed

JSON-RPC API: User's Password #282

c0da opened this issue Oct 5, 2017 · 5 comments

Comments

@c0da
Copy link

c0da commented Oct 5, 2017

Hello everyone,

I've started playing with the JSO-RPC Api, and noticed that every time the server sends an update (next song event, play, pause, etc), it includes my user and password in the body. Something like this:

root@debian:~# telnet localhost 1705
Trying ::1...
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
{"jsonrpc":"2.0","method":"Stream.OnUpdate","params":{"id":"Spotify","stream":{"id":"Spotify","status":"playing","uri":{"fragment":"","host":"","path":"/librespot","query":{"bitrate":"320","buffer_ms":"20","codec":"flac","devicename":"Nova","name":"Spotify","password":"XXXX","sampleformat":"44100:16:2","username":"XXXX"},"raw":"spotify:///librespot?name=Spotify&username=XXXX&password=XXXX&devicename=Nova&bitrate=320","scheme":"spotify"}}}}

It just seems that anyone on my network could telnet to that port and see my user/pass. Is this the normal behaviour, something misconfigured, or a security bug?

Thanks in advance!

@ThYpHo0n
Copy link

ThYpHo0n commented Oct 5, 2017

I observed that behaviour just yesterday on my setup too. Maybe just prevent the username/password from getting exposed and string replaced in the raw string would be enough?

@badaix
Copy link
Owner

badaix commented Oct 6, 2017

It's "normal behaviour" and should definitely be changed

@badaix
Copy link
Owner

badaix commented Oct 10, 2017

fixed a490402

@badaix badaix closed this as completed Oct 10, 2017
@c0da
Copy link
Author

c0da commented Oct 10, 2017

Excuse me @badaix, do you create a new .deb package every time you fix a bug, or should I compile from source?. Thanks in advance!

@badaix
Copy link
Owner

badaix commented Oct 10, 2017

Not for every bug. But the v0.12.0 will be released soon (I hope during the next weekend).
Sometimes I'm closing bugs after having built a release and sometimes when the bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants