-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some StarDict dictionnaries have their html tags exposed when converted. #253
Comments
This particular definition breaks the HTML detection routine: the first non-blank character is \ and not <. |
All the definitions are formatted the same sadly, the English dictionary as well. I'm guessing other languages provided by the repo does too. Would it be possible to fix it? |
You can try the fix by amending |
Out of curiosity, should we change something on our side in https://github.com/BoboTiG/ebook-reader-dict to prevent using hacks or reconverting dicts? |
I am not a dev but I am guessing replacing backslashes |
If the first non-blank character in the definition is |
Since the issue has yet to be resolved by either Plato nor BoboTIG, can someone guide me on what exactly to edit in the convert-dictionary.sh? |
On Plato's side, the issue was resolved on August 27, 2022 by 67bd7fb. |
Unfortunately the fix worked for english, but not all dictionaries. |
I just noticed another bug in the english dictionary: all the definitions end with a closing html tag but have no opening tag. |
--version Plato 0.9.30
--device Kobo Libra h20
Following theses instructions, I added StarDict dictionaries from ebook-reader-dict in the /dictionaries/ folder.
It used to work fine a couple of months ago but since I updated the dictionaries today, I have a formatting issue where html tags for font style are visible (see the following image):
Not sure if I did something wrong or if BoboTiG changed the formatting of their dictionaries.
The text was updated successfully, but these errors were encountered: