Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Shelless invocation for container_run_and_commit #2240

Open
ding-ma opened this issue Mar 28, 2023 · 1 comment
Open

Shelless invocation for container_run_and_commit #2240

ding-ma opened this issue Mar 28, 2023 · 1 comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not

Comments

@ding-ma
Copy link

ding-ma commented Mar 28, 2023

🚀 feature request

Relevant Rules

Run the command without invoke /bin/sh. This would be particularly useful in the distroless project.

Description

In a dockerfile, we can run a command as RUN ["poetry", "install", "--no-cache"] where it runs the poetry binary directly.

Describe the solution you'd like

Use a 2d list for container_run_and_commit. If there is a 2d list, container_run_and_commit should execute the binary directly without invoking /bin/sh.

    container_run_and_commit(
        name = java_version + "_" + arch + "_" + distro + "_install",
        commands = [
           ["poetry", "install", "--no-cache"]
        ],
        image = java_version + "_amd64_" + distro + "_installer.tar",
    )

Describe alternatives you've considered

Cannot execute any binaries in a distroless setting.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

No branches or pull requests

1 participant