Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many rpm tests are not running under bazel 7 (bzlmod) #862

Open
aiuto opened this issue Apr 24, 2024 · 2 comments
Open

Many rpm tests are not running under bazel 7 (bzlmod) #862

aiuto opened this issue Apr 24, 2024 · 2 comments
Labels
bug P2 An issue that should be worked on when time is available

Comments

@aiuto
Copy link
Collaborator

aiuto commented Apr 24, 2024

Now that bazel 7 is the default for CI, and we are using bzlmod, the toolchain finder does not work. Worse than failing, they just silently skip, so it's as good as not having the tests.

//tests/rpm:analysis_tests_conflicting_inputs_base_case_passes_analysis SKIPPED
//tests/rpm:analysis_tests_conflicting_inputs_conflict_with_dir         SKIPPED
//tests/rpm:analysis_tests_conflicting_inputs_conflict_with_file        SKIPPED
//tests/rpm:analysis_tests_conflicting_inputs_conflict_with_symlink     SKIPPED
//tests/rpm:analysis_tests_naming_no_extra                              SKIPPED
//tests/rpm:analysis_tests_naming_with_different_name                   SKIPPED
//tests/rpm:pkg_rpm_basic_test                                          SKIPPED
//tests/rpm:pkg_rpm_smoke                                               SKIPPED
//tests/rpm:test_golden_sub_rpm_contents                                SKIPPED
//tests/rpm:test_rpm_dirs_contents_golden_test                          SKIPPED
//tests/rpm/source_date_epoch:source_date_epoch_from_file               SKIPPED
//tests/rpm/source_date_epoch:source_date_epoch_insource                SKIPPED
//tests/rpm/tree_artifacts:layer_with_files                             SKIPPED
//tests/rpm/tree_artifacts:layer_with_files_reversed                    SKIPPED
//tests/rpm/tree_artifacts:treeartifact_ops                             SKIPPED
@aiuto aiuto added bug P2 An issue that should be worked on when time is available labels Apr 24, 2024
@kellyma2
Copy link
Contributor

do you have a bit more context on where you're encountering this? I ran across this while pushing another PR and decided to check it out a bit, but I'm not encountering this when I'm running locally nor in my latest PR.

@aiuto
Copy link
Collaborator Author

aiuto commented Apr 25, 2024

I think the bzlmod extension that finds the toolchain is just wrong. I implemented it in a hurry and may have just missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P2 An issue that should be worked on when time is available
Projects
None yet
Development

No branches or pull requests

2 participants