New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track pip-compile USERPROFILE workaround #2121

Open

aignas opened this issue Aug 15, 2024 · 1 comment

Collaborator

aignas commented Aug 15, 2024

Based on #1067

Once the issue is fixed upstream, we can remove our workaround.

aignas mentioned this issue

feat: update compile_pip_requirements to support multiple input files #1067

Merged

Contributor

cj81499 commented Aug 26, 2024 •

edited

Loading

Heads up: pypa/distutils#278 merged.

What still remains is:

setuptools needs to "vendor" the change made to distutils
a new version of setuptools needs to be released
rules_python needs to upgrade to a version of setuptools that include the change

then, I believe it may be okay to remove the workaround.

However, it may be best to keep the workaround (and perhaps even expand it to behave similarly on other platforms). See: pypa/distutils#278 (comment) pypa/distutils#278 (comment) pypa/distutils#278 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment