Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude em-http-request on Ruby 3.4 #1070

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Sep 22, 2024

The current version of em-http-request (1.1.7) is not compatible with Ruby HEAD (see igrigorik/em-http-request#365).

Skip tests for the em-http-request integration on Ruby 3.4 for now in order to allow the other tests to complete.

Best reviewed with “ignore white-space”.

@c960657 c960657 mentioned this pull request Sep 22, 2024
@bblimke
Copy link
Owner

bblimke commented Sep 22, 2024

@c960657 Thanks for this PR! I believe the skip solution fits well for the temporary em-http-request issue.

However, I'm not sure the JRuby case should use skip as well. em-http-request has never supported and likely never will support Java. Therefore, I believe using skip will unnecessarily clutter RSpec output. The specs for em-http-request should never run on the Java platform in my opinion.

@c960657
Copy link
Contributor Author

c960657 commented Sep 23, 2024

Ok, I reversed that part.

@@ -3,7 +3,6 @@
unless RUBY_PLATFORM =~ /java/
require 'curb'
require 'patron'
require 'em-http'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c960657 why is it important to remove that require?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Ruby HEAD, even require'ing the library will raise because of the missing constant. Removing it here doesn't seem to affect the tests on the other Ruby versions AFAICT.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c960657 thank you for investigating that and explaining 👍

@bblimke bblimke merged commit cd84c06 into bblimke:master Sep 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants