Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs page shows "not added or updated" for Project Summary Report [4] #1844

Open
BCerki opened this issue Aug 8, 2023 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@BCerki
Copy link
Collaborator

BCerki commented Aug 8, 2023

Describe the Bug:

On the diffs page, a diff should only be shown if the user changed a form. In the project summary report section, we see "Project Summary Report not updated" if there's been no change. It's not inaccurate, but it's inconsistent.

I think the CollapsibleFormWidget may be displaying the wrong component for the Project Summary Report (the conditionality in app/components/Form/ProjectSummaryReportFormSummary.tsx looks ok)

Probability (how likely the bug is to happen, scored from 1-5): 3
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")

Effect (how bad the bug is when it does happen, scored from 1-5): 1
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")

Steps to reproduce the behaviour:

  • create a general revision for an IA project
  • navigate to the summary page
  • see a message under the project summary header

Screenshots:
image.png

Additional information:

  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Version: [e.g. 22]
  • Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant