-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve group filters #1479
Improve group filters #1479
Conversation
5522b2d
to
99f811d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very, very nice! A couple of remarks:
- This reintroduces Screen rotation cancels group selection #762. We probably need to move the fix from Remember group selection after screen rotate #1382 to the main activity.
- This essentially reverts ce9a15b. Do we still want the ability to filter on "No group"?
app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryListView.java
Outdated
Show resolved
Hide resolved
42e7aa4
to
7399218
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7399218
to
9c151d8
Compare
Pill group click should be an automatic selection of that category like radio box selection. Click on Work, it should automatically show only Work group. Click on Games, it should now show only Games group.. Like a filter. Clicking on All will clear all filter and shows everything. By this way its easy to switch between the groups with one click. Edit: I see the same from your previous screen share example. Is new implementation different from it? |
@tiniwings thanks for chiming in. The way I implemented this is just like in the screen share you mentioned. After your comment and bazzik's comment over at #914 (comment) we decided to change the pills to a 1-tap in our next update since our users probably prefer it that way. Maybe in the future we will allow multi-select by long pressing but that's not a high priority right now. Will have updates on this soon. |
This PR moves the group filters from the EntryListView to the MainActivity as shown in the screenshots below.
Tapping the "All" placeholder group will uncheck all the groups and set the filter to null.
Changing the filter will make a 'Save' button appear at the end of row to set the selected filter as default.
I'm not entirely sure if the "Save" button at the end of the row is intuitive since it will be quite hidden for our users with less screen estate or with a lot of groups, but I think it does the job for now and we can always look into this in the future.
Fixes #1406
Fixes #914
Closes #628
Closes #1219