From 59cf034e1453cfa0d8f87fc1355ff4792fe9c3a2 Mon Sep 17 00:00:00 2001
From: Eric Eastwood <erice@element.io>
Date: Tue, 11 Jul 2023 17:12:41 -0500
Subject: [PATCH] Better warning in logs when we fail to fetch an alias
 (#15922)

**Before:**
```
Error retrieving alias
```

**After:**
```
Error retrieving alias #foo:bar -> 401 Unauthorized
```

*Spawning from creating the [manual testing strategy for the outbound federation proxy](https://github.com/matrix-org/synapse/pull/15773).*
---
 changelog.d/15922.misc        | 1 +
 synapse/handlers/directory.py | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/15922.misc

diff --git a/changelog.d/15922.misc b/changelog.d/15922.misc
new file mode 100644
index 000000000000..93fc64487759
--- /dev/null
+++ b/changelog.d/15922.misc
@@ -0,0 +1 @@
+Add details to warning in log when we fail to fetch an alias.
diff --git a/synapse/handlers/directory.py b/synapse/handlers/directory.py
index 1e0623c7f87f..623a4e7b1d5d 100644
--- a/synapse/handlers/directory.py
+++ b/synapse/handlers/directory.py
@@ -277,7 +277,9 @@ async def get_association(self, room_alias: RoomAlias) -> JsonDict:
             except RequestSendFailed:
                 raise SynapseError(502, "Failed to fetch alias")
             except CodeMessageException as e:
-                logging.warning("Error retrieving alias")
+                logging.warning(
+                    "Error retrieving alias %s -> %s %s", room_alias, e.code, e.msg
+                )
                 if e.code == 404:
                     fed_result = None
                 else: