From 4b64470bd6cfdfc61f6d854361d474f217098f80 Mon Sep 17 00:00:00 2001
From: hugues de keyzer <odoo@hugues.info>
Date: Tue, 20 Jun 2023 10:35:53 +0200
Subject: [PATCH] [FIX] fix penalty setting resetting on update

fix shift_worker_status.irregular_penalty config parameter resetting to
true when updating the module.
---
 shift_worker_status/data/data.xml | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/shift_worker_status/data/data.xml b/shift_worker_status/data/data.xml
index 4a6106819..c10a2f00b 100644
--- a/shift_worker_status/data/data.xml
+++ b/shift_worker_status/data/data.xml
@@ -1,7 +1,20 @@
 <?xml version="1.0" ?>
 <odoo>
     <data noupdate="1">
-         <record id="param_config_irregular_penalty" model="ir.config_parameter">
+        <!--
+            when this parameter is set to false, the ir.config_parameter is
+            deleted, along with its corresponding ir.model.data record. this
+            normally causes this record to be re-created when updating the
+            module, even though it is set as noupdate, because it is seen as
+            new data, effectively resetting the value to true. the forcecreate
+            property set to false ensures that this record is not recreated on
+            module update.
+        -->
+        <record
+            id="param_config_irregular_penalty"
+            model="ir.config_parameter"
+            forcecreate="false"
+        >
             <field name="key">shift_worker_status.irregular_penalty</field>
             <field name="value">True</field>
         </record>