Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badly formatted json configuration file hangs the IDE #912

Closed
BlueInt32 opened this issue Jun 12, 2023 · 1 comment
Closed

Badly formatted json configuration file hangs the IDE #912

BlueInt32 opened this issue Jun 12, 2023 · 1 comment
Milestone

Comments

@BlueInt32
Copy link

BlueInt32 commented Jun 12, 2023

Steps to reproduce

  • Install Csharpier extension in Visual Studio (Community) or Jetbrains Rider on Windows 10
  • create the following configuration in the expected json file (both .csharpierrc or .csharpierrc.json will reproduce) but with a wrong format, i.e. notice the double quotes missing for properties:
{
    printWidth: 120,
    useTabs: false,
    tabWidth: 4
}
  • Set up csharpier to run on save
  • Save any file (triggers the formatting)

Expected
The formatting does not work, something tells us that the configuration file is badly formatted.

Actual
The IDE (either VS or Rider) completely hangs, nothing can be done except:

  • fixing the file (which un-hangs the IDE immediately)
  • killing the IDE in the task manager
@belav belav added type:bug Something isn't working area:vs area:rider labels Jun 12, 2023
@belav belav added this to the 0.25.0 milestone Jun 12, 2023
@belav belav modified the milestones: 0.25.0, 0.26.0 Jun 24, 2023
@belav belav modified the milestones: 0.26.0, 0.26.3 Nov 17, 2023
@belav belav modified the milestones: 0.26.3, 0.26.4 Nov 29, 2023
@belav belav modified the milestones: 0.26.4, 0.26.5, 0.26.7 Dec 10, 2023
@belav belav modified the milestones: 0.26.7, Planned - Extensions Jan 2, 2024
@belav belav modified the milestones: Planned - Extensions, 0.28.0 Mar 4, 2024
@belav
Copy link
Owner

belav commented Mar 28, 2024

I believe I fixed this problem in #1191, when the cli was throwing an exception the plugins would hang because the cli didn't send back a response indicating it was done trying to format.

@belav belav closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants