Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert random time.sleep in spawn_workers #2777

Closed
blueyed opened this issue Apr 8, 2022 · 1 comment
Closed

Revert random time.sleep in spawn_workers #2777

blueyed opened this issue Apr 8, 2022 · 1 comment

Comments

@blueyed
Copy link

blueyed commented Apr 8, 2022

I came across the following code added in 3ade8e8:

time.sleep(0.1 * random.random())

This adds (random) overhead/slowdown during startup, and from skimming the comments in the issue it was meant for (#514) it is not confirmed to be helping really.

I suggest removing it for faster, more predictable startup.

(A related issue that might help with adding delay during startup: #514)

@benoitc
Copy link
Owner

benoitc commented Oct 14, 2022

imo this 10 year changes is still useful as it ensure to not make the system too busy. I will close it for now, but if you have any production example where it can be useful, I am happy to revisit this isssue.

@benoitc benoitc closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants