Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #7

Open
mwerle opened this issue Jun 21, 2020 · 1 comment
Open

Code refactoring #7

mwerle opened this issue Jun 21, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@mwerle
Copy link
Collaborator

mwerle commented Jun 21, 2020

A lot of the code could do with some refactoring and turn from polling into event-driven code.

This should make the code more readable as well as more performant.
@mwerle mwerle added the enhancement New feature or request label Jun 21, 2020
@mwerle
Copy link
Collaborator Author

mwerle commented Jun 22, 2020

After some profiling, this is probably not so much an issue. Most of the heavy code is only run rarely, such as when we change the active ship. Might need some feedback from people with less powerful computers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwerle