Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose up #29

Open
sjathin opened this issue May 16, 2021 · 6 comments
Open

Docker Compose up #29

sjathin opened this issue May 16, 2021 · 6 comments
Labels
good first issue Good for newcomers

Comments

@sjathin
Copy link
Collaborator

sjathin commented May 16, 2021

Describe the bug
Docker compose up not running

To Reproduce
Steps to reproduce the behavior:

  1. cd SchedulingSimulation\SchedulingSimulator\
  2. docker compose up
  3. I get the error - Command "compose up" not available in current context (default)

Expected behavior
The application must be executed in a docker container

Proposed Solution
I tried with docker-compose up and works Should it be docker-compose up ?

@sjathin sjathin added bug Something isn't working to be reviewed Closer look at this issue/enhancement to determine if needs to be implemented labels May 16, 2021
@sjathin
Copy link
Collaborator Author

sjathin commented May 16, 2021

I think this was a typo in the readme

@sjathin
Copy link
Collaborator Author

sjathin commented May 16, 2021

Oh this was not a typo, I had an older version of docker. During update I see this message -
Docker Compose is now in the Docker CLI, try docker compose up
After I update docker compose up works

Would it be better to mention the docker CLI in the readme?

@bhatvineeth
Copy link
Owner

bhatvineeth commented May 16, 2021

No it is not a typo. Docker cli will be included in the docker package if you download the latest version. So no need to mention it in readme.

@bhatvineeth
Copy link
Owner

We can add both commands but shouldn't matter. New installations will have compose in docker cli so it will accept the command

@bhatvineeth bhatvineeth removed the bug Something isn't working label May 16, 2021
@sjathin sjathin added the good first issue Good for newcomers label May 16, 2021
@bhatvineeth
Copy link
Owner

We can close this ticket right? What is there to work on it ?

@sjathin
Copy link
Collaborator Author

sjathin commented May 24, 2021

I guess just mentioning the docker version in the readme will suffice. This version number is from when Docker CLI was introduced,

@bhatvineeth bhatvineeth removed the to be reviewed Closer look at this issue/enhancement to determine if needs to be implemented label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants