fix(customer): CHECKOUT-4739 Rename hasAccount to shouldEncourageSign…

…In (#262)
bigcommerce · Apr 16, 2020 · 26ceb63 · 26ceb63
1 parent 134e5cd
commit 26ceb63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/app/customer/Customer.spec.tsx b/src/app/customer/Customer.spec.tsx
@@ -248,12 +248,12 @@ describe('Customer', () => {
             expect(handleChangeViewType).toHaveBeenCalledWith(CustomerViewType.CancellableEnforcedLogin);
         });
 
-        it('renders SuggestedLogin form if continue as guest returns truthy hasAccount', async () => {
+        it('renders SuggestedLogin form if continue as guest returns truthy shouldEncourageSignIn', async () => {
             jest.spyOn(checkoutService.getState().data, 'getCustomer')
                 .mockReturnValue({
                     ...getCustomer(),
                     isGuest: true,
-                    hasAccount: true,
+                    shouldEncourageSignIn: true,
                 } as any);
 
             jest.spyOn(checkoutService, 'continueAsGuest')

diff --git a/src/app/customer/Customer.tsx b/src/app/customer/Customer.tsx
@@ -149,9 +149,9 @@ class Customer extends Component<CustomerProps & WithCheckoutCustomerProps> {
             });
 
             // todo: remove when SDK has been updated
-            const { hasAccount, isGuest } = data.getCustomer() as unknown as CustomerType & { hasAccount: boolean };
+            const { shouldEncourageSignIn, isGuest } = data.getCustomer() as unknown as CustomerType & { shouldEncourageSignIn: boolean };
 
-            if (hasAccount && isGuest) {
+            if (shouldEncourageSignIn && isGuest) {
                 return onChangeViewType(CustomerViewType.SuggestedLogin);
             }