Skip to content

Commit

Permalink
fix(payments): INT-1892 Do not prompt when been redirected to 3DS1 us…
Browse files Browse the repository at this point in the history
…ing Converge
  • Loading branch information
Victor Parra committed Sep 5, 2019
1 parent 48c8c9c commit d984fce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/app/payment/Payment.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,14 @@ class Payment extends Component<PaymentProps & WithCheckoutPaymentProps & WithLa
const { defaultMethod, isSubmittingOrder, language } = this.props;
const { selectedMethod = defaultMethod } = this.state;

// TODO: Perhaps there is a better way to handle `sagepay` and
// `afterpay`. They require a redirection to another website during the
// payment flow but are not categorised as hosted payment methods.
// TODO: Perhaps there is a better way to handle `amazon`, `converge`,
// `sagepay` and `afterpay`. They require a redirection to another website
// during the payment flow but are not categorised as hosted payment methods.
if (!isSubmittingOrder ||
!selectedMethod ||
selectedMethod.type === PaymentMethodProviderType.Hosted ||
selectedMethod.id === PaymentMethodId.Amazon ||
selectedMethod.id === PaymentMethodId.Converge ||
selectedMethod.id === PaymentMethodId.SagePay ||
selectedMethod.gateway === PaymentMethodId.Afterpay) {
return;
Expand Down
1 change: 1 addition & 0 deletions src/app/payment/paymentMethod/PaymentMethodId.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ enum PaymentMethodId {
BraintreeVisaCheckout = 'braintreevisacheckout',
CCAvenueMars = 'ccavenuemars',
ChasePay = 'chasepay',
Converge = 'converge',
Klarna = 'klarna',
Masterpass = 'masterpass',
PaypalExpress = 'paypalexpress',
Expand Down

0 comments on commit d984fce

Please sign in to comment.