Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'scroll-to-fixed' class not removed when element is returned to normal document position #208

Open
sheferd opened this issue Jan 28, 2016 · 2 comments

Comments

@sheferd
Copy link

sheferd commented Jan 28, 2016

I've tried to get the class removed but my JS isn't great.
any ideas?

<nav id="main-navigation" class="main-navigation cf">
$('#main-navigation').scrollToFixed();

EDIT:
It seems to be affected when I change:
baseClassName:"scroll-to-fixed-fixed"
to
baseClassName:"stf-fixed"

@nobodyelses
Copy link
Contributor

Looking at what the code has become, I would say use "className": "stf-fixed" instead of "baseClassName" to have css control over fixed vs unfixed. This seems to be more consistent with what I see in the code for the fixed vs the unfixed event handling.

@sheferd
Copy link
Author

sheferd commented Jan 28, 2016

Thanks, where do I apply this? I had just edited the baseClassName in the plugin js file

Grawl added a commit to Grawl/ScrollToFixed that referenced this issue Jul 25, 2016
@Grawl Grawl mentioned this issue Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants