Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssOptions is not defined #216

Closed
abdullah opened this issue Jun 15, 2016 · 10 comments
Closed

cssOptions is not defined #216

abdullah opened this issue Jun 15, 2016 · 10 comments

Comments

@abdullah
Copy link

The source of the problem : L148

I fixed the problem by adding cssOptions a "var" tag.

@bigspotteddog
Copy link
Owner

Thanks for letting me know. I will make the same correction.

Grawl added a commit to Grawl/ScrollToFixed that referenced this issue Jul 25, 2016
@Grawl Grawl mentioned this issue Jul 25, 2016
@phalvinayak
Copy link

@Grawl I'm still getting this issue. Also i cannot see var tag in the code.
scrolltofix

@Grawl
Copy link

Grawl commented Aug 27, 2016

@phalvinayak first, I think about you are using not updated minified file, but I don't see .min.js in the file extension, so you probably using wrong version of ScrollToFixed – without my fix.

@phalvinayak
Copy link

@Grawl, I'm using scrollToFixed from npm repository. Please have a look at the below screenshot.
screenshot_6
screenshot_7
screenshot_8

Please let me know what wrong I'm doing.

@Grawl
Copy link

Grawl commented Aug 29, 2016

@phalvinayak if you want to use my fixes now, you should use my fork, i.e. npm i Grawl/ScrollToFixed instead of npm i ScrollToFixed from npm repository. Because ScrollToFixed package on npm is using @bigspotteddog repository, not mine. When my PR will be merged into this repository, my changes will be available on npm package. (I think we have to update it's version to allow npm install new version as update.)

@abdullah
Copy link
Author

@phalvinayak Yes, I read @Grawl's commet, this is true when this repo will updated by @bigspotteddog on npm. You can use it.

@phalvinayak
Copy link

Thanks @Grawl that worked for me.

@phalvinayak
Copy link

@Grawl You fixes worked for me in one scenario, but there's one more place where we need var key word on line #L179 can you please make the changes and make it up such that I can use it from the npm registry.

This scenario comes into picture when fixed content has to start scrolling along with the content. Thanks in advance.

Grawl added a commit to Grawl/ScrollToFixed that referenced this issue Sep 1, 2016
@Grawl
Copy link

Grawl commented Sep 1, 2016

@phalvinayak actually you can make a PR to my fork and I will merge it 😄 but okay I'll just make it myself, again.

Go get it.

make it up such that I can use it from the npm registry

With npm you can install any git repository with package.json, or even install by GitHub username/repo as I mentioned above

@phalvinayak
Copy link

Thanks @Grawl, that info was very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants