[Feature Request] Underline, strikethrough, etc

[acdel123]

I have been trying out Notes. So far, so good. It's a great basic markdown editor/viewer.

I hope this is the right place to request new features.

I am not sure if they are in the original/current markdown specification. But it would be great if you could add support for rendering underline and strikethrough. The former is surrounded by ++, the latter by ~~.

A real bonus would be support of markdown emoji.

Thanks and regards

[billthefarmer]

Underline and strikethrough are possible as there are commonmark extensions. I noticed that the emojies are implemented with a JSON data file. A nice project would be to create a javascript script using this file to implement the emojies as an addon using the script feature in the app.

[billthefarmer]

I have added underline and strikethrough to my MarkdownView library, but JitPack appears to be too busy to build it. So I can't build a new version of Notes until that gets done. However I have written a fairly simplistic emojies.js script which appears to work. It probably needs a bit of TLC from a JavaScript expert. There is also a minimised copy.

[acdel123]

I have added underline and strikethrough to my MarkdownView library, but JitPack appears to be too busy to build it. So I can't build a new version of Notes until that gets done. However I have written a fairly simplistic emojies.js script which appears to work. It probably needs a bit of TLC from a JavaScript expert. There is also a minimised copy.

This is great. I appreciate the very prompt review and update!

[billthefarmer]

OK, I have released a new version.

Curiously, there doesn't seem to be a definitive list of emojis, all the ones I have found have emojis not in the other lists. The :bowtie:, one in the list you linked to is a cheat, it's an image, not a character, as are at least some of the GitHub ones.

[acdel123]

OK, I have released a new version.

Just tried out new version 1.30 that showed up on fdroid.

The underline works as expected.

Strikethrough sort of works.

It strikes through text as desired when text is wrapped by ~~ .

But text wrapped with single ~ also appears as strikethrough. My understanding is that single ~ is for subscript.

[billthefarmer]

See commonmark/commonmark-java#267.

[acdel123]

See commonmark/commonmark-java#267.

Thanks for that info... very annoying that they did this.

[billthefarmer]

I can't find any reference to subscript or superscript in the commonmark spec. Other sites/guides differ, some say use <sub>/<sup>, or _/^, or ~/^. Github says use <sub>/<sup>.

[billthefarmer]

OK, I have added ^sup^ , ^sup and ~sub~, _sub. This breaks GitHub ~strike~, strike, but not ~~strike~~, strike. This will be in the next version.

[acdel123]

OK, I have added ^sup^ , sup and ~sub~, sub. This breaks GitHub ~strike~, strike, but not ~~strike~~, strike. This will be in the next version.

This is great! Thank you very much for making that change.

[acdel123]

This will be in the next version.

Tested 1.31 from fdroid. I have a test file with all markdown tags that I am aware of that I use to test markdown apps. Everything in it appears to be working now.

Thank you for making these updates. It is very much appreciated!