Skip to content

Commit

Permalink
henry/dtra-131/feat: dropdown style and description change for all tr…
Browse files Browse the repository at this point in the history
…ade types (#8727)

* feat: dropdown style and description change for all trade types

* fix: minify svg

* refactor: resolve edge cases

* fix: remove comment

* fix: resolve comments

* fix: add animation, make image scrollable

* refactor: refactor for better maintainability

* fix: circleci issue

* fix: disable animation for now

* fix: indexing to contract type value and change view height for mobile

* fix: remove outerscroll

* fix: trying auto size

* fix: autosizer didnt work

* fix: make words bold

* fix: fix bold

* fix: remove navigation and pagnation

* fix: refactor

* fix: resolve comments

* empty commit

* empty commit

* fix: rearrange glossary based on order

* fix: animation bug

* fix: disable swipe on mobile and animation issue

* fix: remove commented out code

* fix: scroll not working for trade-types

* fix: test

* fix: remove unintended test file
  • Loading branch information
henry-deriv committed Jun 19, 2023
1 parent 49ffe5a commit 1fed937
Show file tree
Hide file tree
Showing 21 changed files with 516 additions and 154 deletions.
4 changes: 3 additions & 1 deletion packages/components/src/components/carousel/carousel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ type TCarousel = {
bullet_color?: string;
bullet_position?: 'bottom' | 'top';
className?: string;
disable_swipe?: boolean;
initial_index?: number;
is_mt5?: boolean;
item_per_window?: number;
Expand All @@ -30,6 +31,7 @@ const Carousel = ({
bullet_color = 'var(--text-less-prominent)',
bullet_position = 'bottom',
className,
disable_swipe = false,
initial_index = 0,
is_mt5,
item_per_window = 1,
Expand Down Expand Up @@ -85,7 +87,7 @@ const Carousel = ({
});

return (
<div {...swipe_handlers} className={className}>
<div {...(disable_swipe ? {} : swipe_handlers)} className={className}>
<div className={classNames('dc-carousel', { 'dc-carousel--mt5': is_mt5 })}>
{sliced_list_length > 1 && (
<Nav
Expand Down
2 changes: 2 additions & 0 deletions packages/shared/src/styles/themes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
--button-primary-light-hover: #{$alpha-color-red-3};
--button-toggle-primary: #{$color-blue-3};
--button-toggle-secondary: #{$color-grey-5};
--button-toggle-alternate: #{$color-white};
// Overlay
--overlay-outside-dialog: #{$alpha-color-black-1};
--overlay-inside-dialog: #{$alpha-color-white-1};
Expand Down Expand Up @@ -247,6 +248,7 @@
--button-primary-light-hover: #{$alpha-color-red-3};
--button-toggle-primary: #{$color-blue-3};
--button-toggle-secondary: #{$color-black-8};
--button-toggle-alternate: #{$color-black-8};
// Overlay
--overlay-outside-dialog: #{$alpha-color-black-1};
--overlay-inside-dialog: #{$alpha-color-black-2};
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

1 comment on commit 1fed937

@vercel
Copy link

@vercel vercel bot commented on 1fed937 Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

deriv-app – ./

binary.sx
deriv-app.vercel.app
deriv-app.binary.sx
deriv-app-git-master.binary.sx

Please sign in to comment.