Skip to content

Commit

Permalink
chore: Welcome Modal Removal (#11830)
Browse files Browse the repository at this point in the history
  • Loading branch information
matin-deriv committed Nov 29, 2023
1 parent 5f81f2d commit 3af6f97
Show file tree
Hide file tree
Showing 24 changed files with 13 additions and 1,045 deletions.
2 changes: 2 additions & 0 deletions packages/components/src/components/icon/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,9 @@ import './common/ic-cross-solid.svg';
import './common/ic-cross.svg';
import './common/ic-dashboard-component-tab.svg';
import './common/ic-dashboard-dbot-icon.svg';
import './common/ic-dbot-close.svg';
import './common/ic-dbot-download.svg';
import './common/ic-dbot-no-search-result.svg';
import './common/ic-dbot-user-guide.svg';
import './common/ic-dbot-view-detail.svg';
import './common/ic-delete.svg';
Expand Down
7 changes: 7 additions & 0 deletions packages/components/stories/icon/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,9 @@ export const icons =
'IcCross',
'IcDashboardComponentTab',
'IcDashboardDbotIcon',
'IcDbotClose',
'IcDbotDownload',
'IcDbotNoSearchResult',
'IcDbotUserGuide',
'IcDbotViewDetail',
'IcDelete',
Expand Down Expand Up @@ -406,6 +408,7 @@ export const icons =
'IcEmptyStar',
'IcEwallet',
'IcEye',
'IcFacebook',
'IcFilter',
'IcFolderOpenFilled',
'IcFolderOpen',
Expand Down Expand Up @@ -573,6 +576,8 @@ export const icons =
'IcSelfieVerification',
'IcSelfie',
'IcSendMessage',
'IcShareLink',
'IcShare',
'IcSkrillDark',
'IcSkrillLight',
'IcSort',
Expand All @@ -586,6 +591,7 @@ export const icons =
'IcStop',
'IcSuccessResetTradingPassword',
'IcSuccess',
'IcTelegram',
'IcTheme',
'IcThumbsDown',
'IcThumbsUp',
Expand Down Expand Up @@ -621,6 +627,7 @@ export const icons =
'IcWebTerminal',
'IcWebsite',
'IcWhatsApp',
'IcWhatsappFilled',
'IcWindowsLogo',
'IcWindows',
'IcWip',
Expand Down
5 changes: 1 addition & 4 deletions packages/components/stories/index.stories.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { storiesOf } from '@storybook/react';
import { action } from '@storybook/addon-actions';
import { linkTo } from '@storybook/addon-links';
import { Button, Welcome } from '@storybook/react/demo';
import { Button } from '@storybook/react/demo';
import React from 'react';

storiesOf('Welcome', module).add('to Storybook', () => <Welcome showApp={linkTo('Button')} />);

storiesOf('Button', module)
.add('with text', () => <Button onClick={action('clicked')}>Hello Button</Button>)
.add('with some emoji', () => (
Expand Down
7 changes: 0 additions & 7 deletions packages/core/src/App/Containers/Modals/app-modals.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ const SetResidenceModal = React.lazy(() =>
const RealityCheckModal = React.lazy(() =>
moduleLoader(() => import(/* webpackChunkName: "reality-check-modal" */ '../RealityCheckModal'))
);
const WelcomeModal = React.lazy(() =>
moduleLoader(() => import(/* webpackChunkName: "welcome-modal" */ '../WelcomeModal'))
);
const ResetEmailModal = React.lazy(() => import(/* webpackChunkName: "reset-email-modal" */ '../ResetEmailModal'));

const UpdateEmailModal = React.lazy(() => import(/* webpackChunkName: "update-email-modal" */ '../UpdateEmailModal'));
Expand All @@ -63,7 +60,6 @@ const InformationSubmittedModal = React.lazy(() =>
const AppModals = ({
is_account_needed_modal_on,
is_closing_create_real_account_modal,
is_welcome_modal_visible,
is_reality_check_visible,
is_set_residence_modal_visible,
is_logged_in,
Expand Down Expand Up @@ -145,8 +141,6 @@ const AppModals = ({
ComponentToLoad = <WarningScamMessageModal />;
} else if (is_closing_create_real_account_modal) {
ComponentToLoad = <WarningCloseCreateRealAccountModal />;
} else if (is_welcome_modal_visible) {
ComponentToLoad = <WelcomeModal />;
} else if (is_account_needed_modal_on) {
ComponentToLoad = <MT5AccountNeededModal />;
} else if (is_reality_check_visible) {
Expand Down Expand Up @@ -187,7 +181,6 @@ const AppModals = ({
};

export default connect(({ client, ui, traders_hub }) => ({
is_welcome_modal_visible: ui.is_welcome_modal_visible,
is_account_needed_modal_on: ui.is_account_needed_modal_on,
is_closing_create_real_account_modal: ui.is_closing_create_real_account_modal,
is_set_residence_modal_visible: ui.is_set_residence_modal_visible,
Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/App/Containers/WelcomeModal/index.js

This file was deleted.

79 changes: 0 additions & 79 deletions packages/core/src/App/Containers/WelcomeModal/welcome-item.jsx

This file was deleted.

50 changes: 0 additions & 50 deletions packages/core/src/App/Containers/WelcomeModal/welcome-modal-1.jsx

This file was deleted.

Loading

1 comment on commit 3af6f97

@vercel
Copy link

@vercel vercel bot commented on 3af6f97 Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

deriv-app – ./

deriv-app.binary.sx
binary.sx
deriv-app-git-master.binary.sx
deriv-app.vercel.app

Please sign in to comment.