adrienne/chore: load Onfido through CDN (#10581)

* chore: updated onfido test cases * Update onfido-sdk-view-container.tsx * Update index.html
binary-com · Oct 11, 2023 · cdf8c1c · cdf8c1c · vercel · Oct 11, 2023
1 parent 1138070
commit cdf8c1c
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 1,575 deletions.
diff --git a/__mocks__/globals.js b/__mocks__/globals.js
@@ -2,3 +2,9 @@
 jest.mock('copy-anything', () => ({
     copy: jest.fn(),
 }));
+
+const mock_onfido = {
+    init: jest.fn().mockResolvedValue({}),
+};
+
+window.Onfido = mock_onfido;
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/account/package.json b/packages/account/package.json
@@ -43,7 +43,6 @@
         "js-cookie": "^2.2.1",
         "mobx": "^6.6.1",
         "mobx-react": "^7.5.1",
-        "onfido-sdk-ui": "^11.0.0",
         "prop-types": "^15.7.2",
         "qrcode.react": "^1.0.0",
         "react": "^17.0.2",

diff --git a/packages/account/src/Containers/__tests__/routes.spec.tsx b/packages/account/src/Containers/__tests__/routes.spec.tsx
@@ -10,10 +10,6 @@ jest.mock('Components/Routes', () => ({
     BinaryRoutes: jest.fn(() => 'MockedBinaryRoutesComponent'),
 }));
 
-jest.mock('onfido-sdk-ui', () => ({
-    init: jest.fn().mockResolvedValue({}),
-}));
-
 jest.mock('@deriv/components', () => ({
     ...jest.requireActual('@deriv/components'),
     PageError: jest.fn(() => 'MockedPageErrorComponent'),

diff --git a/...t/src/Sections/Verification/ProofOfIdentity/__tests__/proof-of-identity-container.spec.js b/...t/src/Sections/Verification/ProofOfIdentity/__tests__/proof-of-identity-container.spec.js
@@ -19,10 +19,6 @@ jest.mock('@deriv/components', () => ({
     Loading: jest.fn(() => 'mockedLoading'),
 }));
 
-jest.mock('onfido-sdk-ui', () => ({
-    init: jest.fn().mockResolvedValue({}),
-}));
-
 jest.mock('../../Helpers/verification.js', () => ({
     populateVerificationStatus: jest.fn().mockReturnValue({
         is_age_verified: false,

diff --git a/packages/account/src/Sections/Verification/ProofOfIdentity/onfido-sdk-view-container.tsx b/packages/account/src/Sections/Verification/ProofOfIdentity/onfido-sdk-view-container.tsx
@@ -1,6 +1,5 @@
 import React, { useCallback } from 'react';
 import countries from 'i18n-iso-countries';
-import type { SdkHandle, SdkResponse, SupportedLanguages } from 'onfido-sdk-ui';
 import { CSSTransition } from 'react-transition-group';
 import { GetSettings, ResidenceList } from '@deriv/api-types';
 import { Loading, ThemedScrollbars } from '@deriv/components';
@@ -35,6 +34,11 @@ type TOnfidoSdkViewContainer = {
     is_default_enabled?: boolean;
 };
 
+// TODO: Update types for this later once bundle and CDN issue with Onfido is resolved
+type SdkHandle = any;
+type SupportedLanguages = any;
+type SdkResponse = any;
+
 const OnfidoSdkViewContainer = ({
     account_settings,
     country_code,
@@ -99,9 +103,7 @@ const OnfidoSdkViewContainer = ({
         async (service_token: string) => {
             if (!service_token) return;
             try {
-                const onfido = await import('onfido-sdk-ui');
-
-                onfido_init.current = await onfido.init({
+                onfido_init.current = await window.Onfido.init({
                     containerId: 'onfido',
                     language: {
                         locale: (getLanguage().toLowerCase() as SupportedLanguages) || 'en',

diff --git a/packages/appstore/webpack.config.js b/packages/appstore/webpack.config.js
@@ -182,33 +182,6 @@ module.exports = function (env) {
                       new CssMinimizerPlugin(),
                   ]
                 : [],
-            splitChunks: {
-                chunks: 'all',
-                minChunks: 1,
-                cacheGroups: {
-                    default: {
-                        minChunks: 2,
-                        minSize: 102400,
-                        priority: -20,
-                        reuseExistingChunk: true,
-                    },
-                    account: {
-                        idHint: 'account',
-                        test: /[\\/]account\//,
-                        priority: -20,
-                    },
-                    onfido: {
-                        idHint: 'onfido',
-                        test: /[\\/]onfido\//,
-                        priority: -10,
-                    },
-                    defaultVendors: {
-                        idHint: 'vendors',
-                        test: /[\\/]node_modules[\\/]/,
-                        priority: -10,
-                    },
-                },
-            },
         },
         devtool: is_release ? 'source-map' : 'eval-cheap-module-source-map',
         externals: [

diff --git a/packages/core/src/index.html b/packages/core/src/index.html
@@ -156,6 +156,10 @@
         </script>
         <!-- End URL Handler -->
 
+        <!--         TODO: Find alternative solution for Onfido dependency -->
+        <script src="https://assets.onfido.com/web-sdk-releases/latest/onfido.min.js"></script>
+        <link href="https://assets.onfido.com/web-sdk-releases/latest/style.css" rel="stylesheet" />
+
         <!-- Start Cookies script -->
         <script src="https://static.deriv.com/scripts/cookie.js" async></script>
         <!-- End Cookies script -->

diff --git a/types/global.d.ts b/types/global.d.ts
@@ -13,6 +13,9 @@ declare global {
         };
         TrackJS: { console: { log: (arg0: unknown[]) => void }; track: (arg0: object) => void };
         Blockly;
+        Onfido: {
+            init: (args: any) => any;
+        };
     }
 }