Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamza/CFD-1110/ use trading platform password change hook creation and changing password #10025

Conversation

hamza-deriv
Copy link
Contributor

@hamza-deriv hamza-deriv commented Sep 12, 2023

Changes:

Please provide a summary of the change.
Create a hook to handle the account password change for all of our CFD platforms.

UseCase:

  • This hook is needed if we don't have any MT5 account so first we call change_password API then account creation API can be called.
  • This is also used after reset_password API
  • trading_platform_password_change (hook needs to be created)

Hook Created :

useTradingPlatformPasswordChange
Example data:

const {mutate: tradingPlatformPasswordChange} = useTradingPlatformPasswordChange();
useTradingPlatformPasswordChange({
    new_password: 'password',
    platform:'mt5', 
});

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 12, 2023 8:38am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10025](https://github.com/binary-com/deriv-app/pull/10025)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-usetradingplatformp-1d0e75.binary.sx?qa_server=red.binaryws.com&app_id=24167
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-usetradingplatformp-1d0e75.binary.sx
- **App ID**: `24167`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-usetradingplatformp-1d0e75.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.228% (-0.003%) from 10.231% when pulling d2df071 on hamza-deriv:hamza/useTradingPlatformPasswordChange-hook-creation-and-changing-password into 5888d4e on binary-com:master.

packages/api/src/hooks/index.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yashim-deriv yashim-deriv merged commit 27c94a2 into binary-com:master Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants