Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update bot name on saving bot #10048

Conversation

shafin-deriv
Copy link
Contributor

The strategy name is not updated under the "Your bots" section on the dashboard on saving from the bot builder page.

Changes:

  • Changed the sequence of code execution order.
  • Updated the bot name in the store first and then called the saving method.

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 13, 2023 5:36am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10048](https://github.com/binary-com/deriv-app/pull/10048)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-716fix-updat-a1f8ae.binary.sx?qa_server=red.binaryws.com&app_id=32883
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-716fix-updat-a1f8ae.binary.sx
- **App ID**: `32883`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-716fix-updat-a1f8ae.binary.sx/

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit 8ac2c1a into binary-com:master Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants