Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamza/chore: cTrader- Show icons to download cTrader mobile apps(Android) #10518

Merged

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.
Show icons to download cTrader mobile apps(Android)
Please make sure the links are directing the user to the correct platform. Test both links and QR codes for proper redirection before releasing the card from QA.

Screenshots:

Please provide some screenshots of the change.
image
image

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 16, 2023 0:59am

@hamza-deriv hamza-deriv changed the title chore: cTrader- Show icons to download cTrader mobile apps(Android) Hamza/chore: cTrader- Show icons to download cTrader mobile apps(Android) Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10518](https://github.com/binary-com/deriv-app/pull/10518)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1173mobile-lin-d6a823.binary.sx?qa_server=red.binaryws.com&app_id=32189
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1173mobile-lin-d6a823.binary.sx
- **App ID**: `32189`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1173mobile-lin-d6a823.binary.sx/

Copy link
Contributor

@shontzu-deriv shontzu-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

matin-deriv
matin-deriv previously approved these changes Oct 9, 2023
hirad-deriv
hirad-deriv previously approved these changes Oct 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hirad-deriv hirad-deriv merged commit fb5967f into binary-com:master Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants