Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adrienne / load Onfido through CDN #10581

Merged
merged 7 commits into from
Oct 11, 2023
Merged

adrienne / load Onfido through CDN #10581

merged 7 commits into from
Oct 11, 2023

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 11, 2023 6:41am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10581](https://github.com/binary-com/deriv-app/pull/10581)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-onfido-sdk-html.binary.sx?qa_server=red.binaryws.com&app_id=32875
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-onfido-sdk-html.binary.sx
- **App ID**: `32875`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-onfido-sdk-html.binary.sx/

@adrienne-deriv adrienne-deriv changed the title test: Onfido sdk html adrienne / load Onfido through CDN Oct 11, 2023
@adrienne-deriv adrienne-deriv marked this pull request as ready for review October 11, 2023 04:34
@coveralls
Copy link

coveralls commented Oct 11, 2023 •
edited
Loading

Coverage Status

coverage: 25.291%. remained the same when pulling ecc942b on adrienne-deriv:onfido-sdk-html into 1138070 on binary-com:master.

@yashim-deriv yashim-deriv merged commit cdf8c1c into binary-com:master Oct 11, 2023
3 of 5 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link
Contributor

⏳ Generating Lighthouse report...

vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@adrienne-deriv @vinu-deriv
adrienne/chore: load Onfido through CDN (#10581)
a37205f 
* chore: updated onfido test cases

* Update onfido-sdk-view-container.tsx

* Update index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

Assignees
No one assigned
Labels
Account AppStore Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrienne-deriv @coveralls @balakrishna-deriv @yashim-deriv