Ameerul / P2PS-1732 / Refactor FileUploaderComponent #10650

ameerul-deriv · 2023-10-13T02:39:53Z

Changes:

Please provide a summary of the change.

Migrated FileUploaderComponent to Typescript
Updated test case file to ts as well
Replaced isMobile with is_mobile
Added FileDropzone component from shared to P2P package

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-10-13T02:39:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Dec 20, 2023 2:02am

github-actions · 2023-10-13T02:55:05Z

A production App ID was automatically generated for this PR. (log)

PR: Ameerul / P2PS-1732 / Refactor FileUploaderComponent #10650
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-p2ps-1732-refactor-file-5e1e13.binary.sx?qa_server=red.derivws.com&app_id=32227
- Original: https://deriv-app-git-fork-ameerul-deriv-p2ps-1732-refactor-file-5e1e13.binary.sx
App ID: 32227

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/10650](https://github.com/binary-com/deriv-app/pull/10650)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-1732-refactor-file-5e1e13.binary.sx?qa_server=red.derivws.com&app_id=32227
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-1732-refactor-file-5e1e13.binary.sx
- **App ID**: `32227`

github-actions · 2023-10-13T02:55:43Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	88
🟢 Best practices	92
🟢 SEO	92
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-1732-refactor-file-5e1e13.binary.sx/

packages/p2p/src/components/file-uploader-component/file-uploader-component.tsx

.../components/modal-manager/modals/order-details-confirm-modal/order-details-confirm-modal.jsx

packages/p2p/src/components/file-uploader-component/__test__/file-uploader-component.spec.tsx

packages/p2p/src/components/file-dropzone/file-dropzone.tsx

…t cases

packages/p2p/src/components/file-dropzone/fade-in-message/fade-in-message.tsx

packages/p2p/src/components/file-dropzone/file-dropzone.scss

packages/p2p/src/components/file-dropzone/preview-single/preview-single.tsx

packages/p2p/src/components/file-dropzone/file-dropzone.tsx

coveralls · 2023-11-29T05:48:38Z

coverage: 33.48% (+0.05%) from 33.432%
when pulling b8293b0 on ameerul-deriv:P2PS-1732-refactor-file-uploader-component
into dd87fb0 on binary-com:master.

…32-refactor-file-uploader-component

github-actions · 2023-12-20T01:45:47Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-20T01:45:58Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-20T01:46:08Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-20T01:46:09Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

sonarcloud · 2023-12-20T01:50:03Z

Quality Gate failed

Failed conditions

1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-actions · 2023-12-20T02:02:42Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-20T02:02:43Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-20T02:03:32Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-20T02:03:32Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

chore: migrate FileUploaderComponent to typescript

15d5c68

ameerul-deriv requested review from farrah-deriv and nijil-deriv as code owners October 13, 2023 02:39

boring-cyborg bot added the P2P label Oct 13, 2023

ameerul-deriv deployed to Preview October 13, 2023 02:40 — with GitHub Actions View deployment

fix: failing test cases

e0cd57a

ameerul-deriv deployed to Preview October 13, 2023 03:04 — with GitHub Actions View deployment

farrah-deriv reviewed Oct 13, 2023

View reviewed changes

chore: added suggestions

dbdd87e

ameerul-deriv deployed to Preview October 13, 2023 04:23 — with GitHub Actions View deployment

niloofar-deriv approved these changes Oct 13, 2023

View reviewed changes

chore: moved file-dropzone to p2p package

ce32835

ameerul-deriv deployed to Preview October 16, 2023 07:18 — with GitHub Actions View deployment

nada-deriv reviewed Oct 16, 2023

View reviewed changes

packages/p2p/src/components/file-dropzone/file-dropzone.tsx Outdated Show resolved Hide resolved

chore: moved truncateFileName from shared to utils file and added tes…

ed9d944

…t cases

ameerul-deriv deployed to Preview October 17, 2023 02:45 — with GitHub Actions View deployment

nada-deriv approved these changes Oct 17, 2023

View reviewed changes

fix: regex potential DDos issue

127f008

ameerul-deriv deployed to Preview October 17, 2023 08:00 — with GitHub Actions View deployment

nada-deriv reviewed Oct 18, 2023

View reviewed changes

packages/p2p/src/components/file-dropzone/fade-in-message/fade-in-message.tsx Show resolved Hide resolved

nada-deriv reviewed Oct 18, 2023

View reviewed changes

packages/p2p/src/components/file-dropzone/file-dropzone.scss Outdated Show resolved Hide resolved

nada-deriv reviewed Oct 18, 2023

View reviewed changes

packages/p2p/src/components/file-dropzone/preview-single/preview-single.tsx Show resolved Hide resolved

chore: added suggestions

00384dd

ameerul-deriv deployed to Preview October 19, 2023 03:05 — with GitHub Actions View deployment

nada-deriv approved these changes Oct 19, 2023

View reviewed changes

niloofar-deriv reviewed Oct 19, 2023

View reviewed changes

packages/p2p/src/components/file-dropzone/file-dropzone.tsx Outdated Show resolved Hide resolved

niloofar-deriv approved these changes Oct 19, 2023

View reviewed changes

ameerul-deriv temporarily deployed to Preview November 29, 2023 05:33 — with GitHub Actions Inactive

ameerul-deriv changed the title ~~Ameerul /P2PS-1732 Refactor FileUploaderComponent~~ Ameerul / P2PS-1732 / Refactor FileUploaderComponent Nov 30, 2023

fix: merge conflicts

30d9885

balakrishna-deriv temporarily deployed to Preview December 12, 2023 02:21 — with GitHub Actions Inactive

balakrishna-deriv temporarily deployed to Preview December 12, 2023 02:22 — with GitHub Actions Inactive

ameerul-deriv temporarily deployed to Preview December 12, 2023 02:22 — with GitHub Actions Inactive

fix: merge conflicts

6b66c36

ameerul-deriv had a problem deploying to Preview December 15, 2023 06:45 — with GitHub Actions Failure

Merge branch 'master' of github.com:binary-com/deriv-app into P2PS-17…

153c355

…32-refactor-file-uploader-component

ameerul-deriv had a problem deploying to Preview December 15, 2023 06:57 — with GitHub Actions Failure

ameerul-deriv temporarily deployed to Preview December 15, 2023 06:57 — with GitHub Actions Inactive

fix: flickering Icon on tab switch

c2919cc

ameerul-deriv had a problem deploying to Preview December 15, 2023 07:30 — with GitHub Actions Failure

ameerul-deriv temporarily deployed to Preview December 15, 2023 07:30 — with GitHub Actions Inactive

Merge branch 'master' of github.com:binary-com/deriv-app into P2PS-17…

b8293b0

…32-refactor-file-uploader-component

ameerul-deriv temporarily deployed to Preview December 20, 2023 01:45 — with GitHub Actions Inactive

farrah-deriv merged commit a8451d5 into binary-com:master Jan 4, 2024
4 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ameerul / P2PS-1732 / Refactor FileUploaderComponent #10650

Ameerul / P2PS-1732 / Refactor FileUploaderComponent #10650

ameerul-deriv commented Oct 13, 2023 •

edited

Loading

vercel bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

coveralls commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

sonarcloud bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

Ameerul / P2PS-1732 / Refactor FileUploaderComponent #10650

Ameerul / P2PS-1732 / Refactor FileUploaderComponent #10650

Conversation

ameerul-deriv commented Oct 13, 2023 • edited Loading

Changes:

Screenshots:

vercel bot commented Oct 13, 2023 • edited Loading

github-actions bot commented Oct 13, 2023 • edited Loading

github-actions bot commented Oct 13, 2023 • edited Loading

coveralls commented Nov 29, 2023 • edited Loading

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

sonarcloud bot commented Dec 20, 2023

Quality Gate failed

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

ameerul-deriv commented Oct 13, 2023 •

edited

Loading

vercel bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

coveralls commented Nov 29, 2023 •

edited

Loading