-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WALL-2166 : Base Components - Button #10700
WALL-2166 : Base Components - Button #10700
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/wallets/src/components/Base/WalletButton/WalletButton.tsx
Outdated
Show resolved
Hide resolved
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
packages/wallets/src/components/Base/WalletButton/WalletButton.tsx
Outdated
Show resolved
Hide resolved
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wallet-button-addons.binary.sx/ |
packages/wallets/src/components/Base/WalletButton/WalletButton.tsx
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/Base/WalletButton/WalletButton.tsx
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Screenshots:
Changes:
✅ Added
WalletText
component insideWalletButton
.✅ Users can passed
Icon
andText
directly inside the component.✅ Color, variant and font size mapping is done within
WalletButton
component.✅ Create
types.ts
for generic types i.e.TGenericSizes