Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sergei / wall 2127 / implement simple onboarding steps #10716

Merged
merged 13 commits into from
Oct 17, 2023
Merged

Sergei / wall 2127 / implement simple onboarding steps #10716

merged 13 commits into from
Oct 17, 2023

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Oct 16, 2023 •
edited
Loading

Changes:

  • install react-joyride to wallets package
  • create TooltipComponent for joyride
  • create WalletTourGuide for onboarding
  • add temporary button to start onboarding

Video:

Screen.Recording.2023-10-16.at.22.23.03.mov

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2023 9:49am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10716](https://github.com/binary-com/deriv-app/pull/10716)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-2127implemen-a1c69c.binary.sx?qa_server=red.binaryws.com&app_id=30372
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-2127implemen-a1c69c.binary.sx
- **App ID**: `30372`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-wall-2127implemen-a1c69c.binary.sx/

@coveralls
Copy link

coveralls commented Oct 16, 2023 •
edited
Loading

Coverage Status

coverage: 25.979%. remained the same when pulling c73c788 on sergei-deriv:sergei/wall-2127/implement-simple-onboarding-step into c949695 on binary-com:master.

thisyahlen-deriv
thisyahlen-deriv approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the Wallet Onboarding button before we merge. We dont have QA for this.

@sergei-deriv
Copy link
Contributor Author

Commented button for onboarding

yashim-deriv
yashim-deriv reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanups

packages/wallets/src/routes/WalletsListingRoute/WalletsListingRoute.tsx Outdated Show resolved Hide resolved
packages/wallets/src/routes/WalletsListingRoute/WalletsListingRoute.tsx Outdated Show resolved Hide resolved
packages/wallets/src/routes/WalletsListingRoute/WalletsListingRoute.tsx Outdated Show resolved Hide resolved
@sergei-deriv sergei-deriv force-pushed the sergei/wall-2127/implement-simple-onboarding-step branch from 4d78b95 to b574927 Compare October 17, 2023 08:54
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

@yashim-deriv yashim-deriv merged commit b3606b3 into binary-com:master Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sergei-deriv @coveralls @yashim-deriv @thisyahlen-deriv @farhan-nurzi-deriv