[42069] thisyahlen/chore: code cleanup and change to WalletText #10744

thisyahlen-deriv · 2023-10-17T07:25:24Z

Changes:

Code cleanup
Add WalletText to replace all p, span and h1 tags
Remove text styles
Add line-height to WalletText

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-10-17T07:25:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Oct 17, 2023 8:26am

sergei-deriv · 2023-10-17T07:36:35Z

packages/wallets/src/components/Base/WalletText/WalletText.tsx

-    children: React.ReactNode;
-    color?: 'black' | 'error' | 'general' | 'primary' | 'success' | 'warning' | 'white';
+    children: ReactNode;
+    color?: CSSProperties['color'] | 'error' | 'general' | 'primary' | 'success' | 'warning';


@thisyahlen-deriv what about colors black, blue, white which still exist in scss file, please, add these colors to the type. Also, JFYI, I added red color with value #ff444f because I needed it for onboarding title

Black, blue, white, red, purple and all generic colors will come from CSSProperties['color']. 😸

@thisyahlen-deriv got it, didn't notice it, nice 👍

coveralls · 2023-10-17T07:37:53Z

coverage: 25.976%. remained the same when pulling 4537384 on thisyahlen-deriv:thisyahlen/code_cleanup into 19baca9 on binary-com:master.

github-actions · 2023-10-17T07:42:55Z

A production App ID was automatically generated for this PR. (log)

PR: [42069] thisyahlen/chore: code cleanup and change to WalletText #10744
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-codecleanup.binary.sx?qa_server=red.binaryws.com&app_id=23888
- Original: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-codecleanup.binary.sx
App ID: 23888

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/10744](https://github.com/binary-com/deriv-app/pull/10744)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-codecleanup.binary.sx?qa_server=red.binaryws.com&app_id=23888
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-codecleanup.binary.sx
- **App ID**: `23888`