Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallets] WALL-2240: Feature/wall AppLinked card #11078

Merged

Conversation

wojciech-deriv
Copy link
Contributor

Changes:

Added WalletsAppLinkedWithWalletIcon component.
Added first tests within wallets area.

CU: https://app.clickup.com/t/20696747/WALL-2240

Screenshots:

Screenshot 2023-10-31 at 11 06 15

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 2, 2023 8:44am

Copy link
Contributor

github-actions bot commented Oct 31, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11078](https://github.com/binary-com/deriv-app/pull/11078)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-wall-2240-linked-card.binary.sx?qa_server=red.derivws.com&app_id=24204
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-wall-2240-linked-card.binary.sx
- **App ID**: `24204`

Copy link
Contributor

github-actions bot commented Oct 31, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-wall-2240-linked-card.binary.sx/

Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than icons need re-ordering, LGTM 👍

Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.3% 2.3% Duplication

Copy link
Contributor

github-actions bot commented Nov 2, 2023

🚀 Smoke test run (1) passed successfully!

@wojciech-deriv wojciech-deriv merged commit e6f5568 into binary-com:master Nov 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants