-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] george / Fix UI inconsistencies in CashierWalletHeader component #11145
[Wallet] george / Fix UI inconsistencies in CashierWalletHeader component #11145
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-86bwavj4q-fix-cashier-he-636109.binary.sx/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3fd9c2c
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
🚀 Smoke test run (1) passed successfully! |
🚀 Smoke test run (2) passed successfully! |
…nent (binary-com#11145) * style: 💄 fix icon xl size, jurisdiction badge, text xl line-height size * style: 💄 add gap in mobile view * style: 🎨 replace svg fiat currency icons with proper ones
…nent (binary-com#11145) * style: 💄 fix icon xl size, jurisdiction badge, text xl line-height size * style: 💄 add gap in mobile view * style: 🎨 replace svg fiat currency icons with proper ones
Changes:
line-height
forWalletText
componentxl
size from 34px to 36pxrounded
currency icon sizexl
from 56px to 64pxWalletListCardBadge
(Jurisdiction Badge), add fixed height, replace border to outlineCashierWalletHeader
componentScreenshots: