Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farabi/quick-strategy-initial-stake-issue #11151

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Farabi/quick-strategy-initial-stake-issue #11151

merged 2 commits into from
Nov 3, 2023

Conversation

farabi-deriv
Copy link
Contributor

@farabi-deriv farabi-deriv commented Nov 3, 2023 •
edited
Loading

Changes:

  • Initial stake Nan issue fix
  • Fixed error message for max stake
  • Trade type style fix

@boring-cyborg boring-cyborg bot added the Bot label Nov 3, 2023
review-deriv
review-deriv reviewed Nov 3, 2023
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel Vercel
Copy link

vercel bot commented Nov 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 3, 2023 6:38am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11151](https://github.com/binary-com/deriv-app/pull/11151)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-oscar-grind-improvements.binary.sx?qa_server=red.derivws.com&app_id=24104
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-oscar-grind-improvements.binary.sx
- **App ID**: `24104`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-oscar-grind-improvements.binary.sx/

@farabi-deriv farabi-deriv changed the title Farabi/oscar-grind-improvements Farabi/quick-strategy-initial-stake-issue Nov 3, 2023
review-deriv
review-deriv reviewed Nov 3, 2023
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

🚀 Smoke test run (1) passed successfully!

@vinu-deriv vinu-deriv merged commit c6e5f24 into binary-com:feature/bot-max-stake Nov 3, 2023
7 checks passed
sandeep-deriv added a commit that referenced this pull request Nov 6, 2023
@sandeep-deriv @farabi-deriv
feat: quick-strategy - add max stake with updated martingale (#10993) (…
b801f90 
…#11146)

* feat: quick-strategy - add max stake with updated martingale (#10993)

* feat: quick-strategy - add max stake with updated martingale

* feat: quick-strategy - max-stake style done

* feat: quick-strategy field alignment done

* feat: quick-strategy - adding max-stake and related settings

* feat: quick-strategy max-stake and contract-type implementation

* feat: quick-strategy max-stake and contract-type coverage

* feat: quick-strategy max-stake - made tradetype fullwidth

* feat: quick-strategy styles cleanup

* feat: quick-strategy max_stake should be less than initial stake

* feat: quick-strategy coverage and TS cleanup

* feat: quick-strategey max_stake qs-input coverage correction

* feat: quick-strategey max_stake qs-input coverage correction cleanup

* Farabi/quick-strategy-initial-stake-issue (#11151)

* fix: removed unit field

* fix: initial stake Nan issue and trade type style

* fix: qs-duration-style (#11176)

---------

Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-deriv review-deriv review-deriv left review comments

@vinu-deriv vinu-deriv vinu-deriv approved these changes

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv

Assignees
No one assigned
Labels
Bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farabi-deriv @vinu-deriv @review-deriv