[Wallets] Rostislav / WALL-2443 / Align TransactionStatus header font size with Figma
#11180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rostislav-deriv
requested review from
adrienne-deriv,
thisyahlen-deriv,
farhan-nurzi-deriv and
wojciech-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rostislav-deriv
changed the title
TransactionStatus header font size with FigmaTransactionStatus header font size with Figma
rostislav-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-2443tr-df7d33.binary.sx/ |
rostislav-deriv
commented
Nov 3, 2023
packages/wallets/src/features/cashier/modules/TransactionStatus/TransactionStatus.tsx
Show resolved
Hide resolved
rostislav-deriv
commented
Nov 3, 2023
...r/modules/TransactionStatus/components/TransactionStatusSuccess/TransactionStatusSuccess.tsx
Show resolved
Hide resolved
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
heorhi-deriv
approved these changes
Nov 3, 2023
heorhi-deriv
reviewed
Nov 3, 2023
packages/wallets/src/features/cashier/modules/TransactionStatus/TransactionStatus.tsx
Outdated
Show resolved
Hide resolved
nijil-deriv
previously approved these changes
Nov 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
markw-deriv
approved these changes
Nov 3, 2023
heorhi-deriv
approved these changes
Nov 3, 2023
nijil-deriv
approved these changes
Nov 3, 2023
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Nov 6, 2023
…nt size with Figma (binary-com#11180) * fix: transaction status font size * fix: `TransactionStatus` no transactions * fix: "No recent transactions" font size also updated * refactor: remove useless usememos, add `isTransactionStatusSuccessVisible`
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Nov 6, 2023
…nt size with Figma (binary-com#11180) * fix: transaction status font size * fix: `TransactionStatus` no transactions * fix: "No recent transactions" font size also updated * refactor: remove useless usememos, add `isTransactionStatusSuccessVisible`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Align
TransactionStatusfont sizes with Figma and fix "No recent transactions." display.Screenshots: