Revert 11034 #11666
Merged
Revert 11034 #11666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-hosseini-deriv
requested review from
farrah-deriv,
nijil-deriv,
wojciech-deriv,
matin-deriv and
mahdiyeh-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-hosseini-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
ali-hosseini-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
…)" This reverts commit f6820b8.
ali-hosseini-deriv
force-pushed
the
revert-11034
branch
from
5d7efe9
to
bb1a060
Compare
ali-hosseini-deriv
requested review from
maryia-deriv and
amina-deriv
as code owners
ali-hosseini-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-revert-11034.binary.sx/ |
|
Kudos, SonarCloud Quality Gate passed!
|
farrah-deriv
approved these changes
Nov 22, 2023
jim-deriv
approved these changes
Nov 22, 2023
ameerul-deriv
approved these changes
Nov 22, 2023
niloofar-deriv
approved these changes
Nov 22, 2023
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |
ali-hosseini-deriv
added a commit
that referenced
this pull request
Nov 22, 2023
ali-hosseini-deriv
added a commit
that referenced
this pull request
Nov 29, 2023
… form (#11665) * Revert "Revert "Shayan/P2PS-1753/refactor exchange rates hook (#11034)" (#11666)" This reverts commit 35062e9. * fix: currency issue in the withdrawal crypto form * test: fix tests * fix: add fallback value for current_fiat_currency * chore: removed unused CookieStorage --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: shayan khaleghparast <iman@regentmarkets.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This is to revert
#11034
and
#11571
Screenshots:
Please provide some screenshots of the change.