Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COJ] Evgeniy/coj-266/Add "I dont have any of these to idv options and redirect to manual" #11996

Merged
merged 27 commits into from
Jan 3, 2024
Merged

[COJ] Evgeniy/coj-266/Add "I dont have any of these to idv options and redirect to manual" #11996

merged 27 commits into from
Jan 3, 2024

Conversation

yauheni-deriv
Copy link
Contributor

For IDV and for Same flow is for failed IDV the option "I don't have any of these" has been added to the flow, after clicking "Next" button user will be navigated to Manual uploading.
The function for getting this option returns this option depending on the flow (Account settings or Real account creation).
"Back" button was added to Manual upload page, and navigates user to country selector.
Timeline component has been removed from Manual upload page.
this PR is new, previous was reverted due to few bugs

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 26, 2023 11:41am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11996](https://github.com/binary-com/deriv-app/pull/11996)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-coj-266-redirecttomanua-4afb77.binary.sx?qa_server=red.derivws.com&app_id=32106
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-coj-266-redirecttomanua-4afb77.binary.sx
- **App ID**: `32106`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-coj-266-redirecttomanua-4afb77.binary.sx/

@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Coverage Status

coverage: 33.874% (+0.1%) from 33.768%
when pulling 1c519a7 on yauheni-deriv:coj-266/redirect_to_manual_if_i_dont_have_any_of_these_chosen
into 23c23d2 on binary-com:master.

“yauheni-kryzhyk-deriv” added 2 commits December 5, 2023 09:49
likhith-deriv
likhith-deriv previously approved these changes Dec 6, 2023
View reviewed changes
shahzaib-deriv
shahzaib-deriv previously approved these changes Dec 7, 2023
View reviewed changes
matin-deriv
matin-deriv previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

likhith-deriv
likhith-deriv previously approved these changes Dec 26, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 26, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@amina-deriv amina-deriv merged commit ef7d53c into binary-com:master Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@likhith-deriv likhith-deriv likhith-deriv left review comments

@shahzaib-deriv shahzaib-deriv shahzaib-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

Assignees
No one assigned
Labels
Account AppStore Bot Components Core P2P Shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yauheni-deriv @coveralls @matin-deriv @amina-deriv @likhith-deriv @shahzaib-deriv